Fix issue in vectorized get_dark_cal_id #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vert to underlying type
javierggt
force-pushed
the
dark-cal-vector-fix
branch
from
856a0c6 to
c049a5d
Compare
taldcroft
reviewed
Jul 8, 2022
mica/archive/aca_dark/dark_cal.py
Outdated
| dark_id = _get_dark_cal_id_vector(date, select=select) | ||
| if not dark_id.shape: | ||
| # returning an instance of the type, not a numpy array | ||
| return dark_id.dtype.type(dark_id) |
There was a problem hiding this comment.
I think that dark_id.tolist() is a more standard idiom to get back to a pure Python representation. In this case tolist() will return a str object instead of a numpy.str_ object. Even though they are basically compatible they are still different object types and the original API was str.
There was a problem hiding this comment.
I changed it to use tolist().
taldcroft
approved these changes
Jul 8, 2022
This was referenced Jul 8, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug found in regression testing.
get_dark_cal_idis vectorized usingnp.vectorize. When the input is a scalar, it returns a numpy scalar, but that is a numpy array with shape(). This has overloaded the bracket operators, so you can't call the bracket operators on the result. The solution is to return a scalar of the dtype's type.Interface impacts
None
Testing
mica unit tests and sparkles tests pass (including a new test for this)
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests